-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): replace hardhat with foundry toolkit #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvrs
commented
Jul 1, 2022
@@ -0,0 +1,45 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the config file in which we declare which components / facets we want to deploy
ludns
previously approved these changes
Jul 4, 2022
ludns
approved these changes
Jul 5, 2022
davidkol
pushed a commit
that referenced
this pull request
Jul 7, 2022
* fix: add missing components and methods to BroadcastDeploy * feat(contracts): move deploy logic to library * feat(contracts): add codegen for deploy script * feat(contracs): add functionality to upgrade diamond * feat(contracts): add functionality to reuse world and components * chore(contracts): remove hardhat, use foundry toolkit for everything * fix(cli): fix mud deploy * feat: add yarn start:ri script to workspace root * fix(cli): add fetch and fix chainSpec parsing * chore: clean up package.json * fix: make deploy script pass local persona contracts to launcher
LPSCRYPT
pushed a commit
to LPSCRYPT/esp
that referenced
this pull request
Jan 23, 2023
* fix: add missing components and methods to BroadcastDeploy * feat(contracts): move deploy logic to library * feat(contracts): add codegen for deploy script * feat(contracs): add functionality to upgrade diamond * feat(contracts): add functionality to reuse world and components * chore(contracts): remove hardhat, use foundry toolkit for everything * fix(cli): fix mud deploy * feat: add yarn start:ri script to workspace root * fix(cli): add fetch and fix chainSpec parsing * chore: clean up package.json * fix: make deploy script pass local persona contracts to launcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation before this PR
Changes in this PR
deploy.json
file for easy configuration of components and diamond facets without having to touch deploy scriptLibDeploy.sol
, which can be used to deploy to real chains as well as in forge testsmud deploy
script to support chainSpec and our new deploy scripts. Mud deploy allows for interactive deployment (you get prompted for every param), command line args or config files.Followup todos: